Fill in some admitted proofs #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gio256
commented
Dec 8, 2024
Comment on lines
12
to
19
| def eHomWhiskerLeftIso (X : C) {Y Y' : C} (i : Y ≅ Y') : | ||
| (X ⟶[V] Y) ≅ (X ⟶[V] Y') where | ||
| hom := eHomWhiskerLeft V X i.hom | ||
| inv := eHomWhiskerLeft V X i.inv | ||
| hom_inv_id := by | ||
| rw [← eHomWhiskerLeft_comp, i.hom_inv_id, eHomWhiskerLeft_id] | ||
| inv_hom_id := by | ||
| rw [← eHomWhiskerLeft_comp, i.inv_hom_id, eHomWhiskerLeft_id] |
There was a problem hiding this comment.
The (two-sided) unenriched analogue appears to be CategoryTheory.Iso.homCongr. Perhaps this deserves a more complete treatment than I've given here (or at least a better name)?
There was a problem hiding this comment.
I added eHomCongr and sHomCongr to be more consistent with the unenriched version of the api here, but I stopped short of adding analogues for all of the additional lemmas in Mathlib/CategoryTheory/HomCongr.lean.
There was a problem hiding this comment.
Update: I implemented a more direct proof of IsSLimit.ofIsoSLimit that removed the need for eHomCongr. I think it's probably still a good thing to eventually have in mathlib, but it doesn't necessarily need to be in this PR.
gio256
changed the title
emilyriehl
approved these changes
Dec 10, 2024
emilyriehl
added a commit
that referenced
this pull request
Dec 10, 2024
* wip * more work on leibniz isofibrations * completed proof of isofibration modulo conical terminal sorries * Fill in some admitted proofs (#64) * Prove IsConicalTerminal.sHomIso * Prove IsConicalTerminal.ofIso * Prove conicalTerminalIsConicalTerminal * Add sHomWhiskerLeftIso and friends * Clean up conicalTerminalIsConicalTerminal * Replace eHomWhiskerLeftIso with eHomCongr * Add IsSLimit.ofIsoSLimit * Remove eHomCongr and sHomCongr --------- Co-authored-by: Nick Ward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the admitted proofs in #58.
This has caused some cascading of
noncomputable, but I wasn't able to find a way around that due tosHomFunctorbeingnoncomputable.