Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new use_synthetic_source_recovery track parameter #713

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Introduce a new use_synthetic_source_recovery track parameter #713

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b867332
feature: introduce a new use_synthetic_source_recovery track parameter
salvatore-campagna Dec 16, 2024
9447535
nit: reword parameter description
salvatore-campagna Dec 16, 2024
ce031fe
fix: remove misplaced comma
salvatore-campagna Dec 17, 2024
31010dd
fix: add missing comma
salvatore-campagna Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions elastic/logs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ The following parameters are available:
* `workflow-request-cache` (default: `true`) - Explicit control of request cache query parameter in searches executed in a workflow. This can be further overriden at an operation level with `request-cache` parameter.
* `synthetic_source_keep` (default: unset) - Allows overriding the default synthetic source behaviour for all field types with the following values: `none` (equivalent to unset) - no source is stored, `arrays` - source stored as is only for multi-value (array) fields.
* `source_mode` (default: unset) - Specifies the source mode to be used.
* `use_synthetic_source_recovery` (default: unset): If `true` recovery will take place using synthetic source instead of using `_recovery_source`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `use_synthetic_source_recovery` (default: unset): If `true` recovery will take place using synthetic source instead of using `_recovery_source`
* `use_synthetic_source_recovery` (default: unset): Whether synthetic recovery source will be used.


### Data Download Parameters

Expand Down
3 changes: 3 additions & 0 deletions elastic/logs/templates/component/track-shared-logsdb-mode.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
{% if index_mode %}
"index": {
"mode": {{ index_mode | tojson }}
{% if use_synthetic_source_recovery %}
,"recovery.use_synthetic_source": {{use_synthetic_source_recovery | tojson}},
{% endif %}
{% if synthetic_source_keep and synthetic_source_keep != 'none' %}
,"mapping.synthetic_source_keep": {{ synthetic_source_keep | tojson }}
{% endif %}
Expand Down
1 change: 1 addition & 0 deletions elastic/security/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ The following parameters are available:
* `index_mode` (default: unset) - A parameter meant to be used internally which defines one of the available indexing modes, "standard", "logsdb" or "time_series". If not set, "standard" is used.
* `synthetic_source_keep` (default: unset) - Allows overriding the default synthetic source behaviour for all field types with the following values: `none` (equivalent to unset) - no source is stored, `arrays` - source stored as is only for multi-value (array) fields.
* `source_mode` (default: unset) - Specifies the source mode to be used.
* `use_synthetic_source_recovery` (default: unset): If `true` recovery will take place using synthetic source instead of using `_recovery_source`

### Data Generation Parameters

Expand Down
3 changes: 3 additions & 0 deletions elastic/security/templates/component/track-shared-logsdb-mode.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
{% if index_mode %}
"index": {
"mode": {{ index_mode | tojson }},
{% if use_synthetic_source_recovery %}
"recovery.use_synthetic_source": {{use_synthetic_source_recovery | tojson}},
{% endif %}
{% if synthetic_source_keep and synthetic_source_keep != 'none' %}
"mapping.synthetic_source_keep": {{ synthetic_source_keep | tojson}},
{% endif %}
Expand Down
1 change: 1 addition & 0 deletions tsdb/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ This track allows to overwrite the following parameters using `--track-params`:
* `post_ingest_sleep_duration` (default: 30): Sleep duration in seconds.
* `document_ids`: documentd IDs to use for search, get and mget apis in the `low-latency` challenge. If empty, a default set of 4 values is used.
* `synthetic_source_keep` (default: unset): If specified, configures the `index.mapping.synthetic_source_keep` index setting.
* `use_synthetic_source_recovery` (default: unset): If `true` recovery will take place using synthetic source instead of using `_recovery_source`

### License

Expand Down
3 changes: 3 additions & 0 deletions tsdb/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"number_of_shards": {{number_of_shards | default(1)}},
"number_of_replicas": {{number_of_replicas | default(0)}},
"requests.cache.enable": false,
{% if use_synthetic_source_recovery %}
"recovery.use_synthetic_source": {{use_synthetic_source_recovery | tojson}},
{% endif %}
{%- endif -%}{# non-serverless-index-settings-marker-end #}
"codec": "{{codec | default('default')}}",
"mode": "{{index_mode | default('time_series')}}",
Expand Down
Loading