Introduce a new use_synthetic_source_recovery track parameter
#713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
approved these changes
Dec 16, 2024
elastic/logs/README.md
Outdated
| @@ -222,6 +222,7 @@ The following parameters are available: | |||
| * `workflow-request-cache` (default: `true`) - Explicit control of request cache query parameter in searches executed in a workflow. This can be further overriden at an operation level with `request-cache` parameter. | |||
| * `synthetic_source_keep` (default: unset) - Allows overriding the default synthetic source behaviour for all field types with the following values: `none` (equivalent to unset) - no source is stored, `arrays` - source stored as is only for multi-value (array) fields. | |||
| * `source_mode` (default: unset) - Specifies the source mode to be used. | |||
| * `use_synthetic_source_recovery` (default: unset): If `true` recovery will take place using synthetic source instead of using `_recovery_source` | |||
There was a problem hiding this comment.
Suggested change
| * `use_synthetic_source_recovery` (default: unset): If `true` recovery will take place using synthetic source instead of using `_recovery_source` | |
| * `use_synthetic_source_recovery` (default: unset): Whether synthetic recovery source will be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR elastic/elasticsearch#114618 in Elasticsearch introduced the ability
to do recovery using synthetic source instead of using the
_recovery_sourcefield.We are updating three Rally tracks,
elastic/logs,elastic/securityandtsdbto include a new parameter,use_synthetic_source_recovery. This parameter will allow us to toggle theindex.mapping.use_synthetic_sourcesetting in Rally nightly benchmarks. We will follow-up with another PR introducing new nightly Elasticsearch benchmarks
to provide a means of comparing the performance impact of enabling versus disabling this setting.