-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove bundled fonts #67
base: master
Are you sure you want to change the base?
Conversation
…issing (most people should be able to load the default font)
I did not explain in the issue, but the envelope with NaN is not actually an error. If a diagram is empty, its envelope should be NaN. Similarly, if a text is the empty string "". If no font is found, we should try to use the one provided in the |
Ah wait I thought these are handled by (Generally we were taught that NaN should generally not be used to communicate useful values, only errors that require attention.) |
You are correct. Its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The asserts looks good! But I'd like to keep a bundled font. Probably the one you suggested.
Perhaps join #68 here and do a single PR?
OK I'll reorganize a little. |
I moved the assert to #68, I guess these are the changes that should be generally "ok to go". That leaves the bundle alone, and should be hopefully mergeable. I'll read up on the TexGyre licensing and see how to move forward here. For now let's have this as a draft. |
80bcd4e
to
7b330e0
Compare
This might be a pretty drastic change for some setups but I believe it's generally for the good of it;
in particular:
Additionally this adds an early assert that catches the NaN values (which may come from defunct fonts as I unfortunately observed in #66 ) early and provides a somewhat useful error message.
If the plain removal of the font bundle is too much, I think we can bundle a different one with clear license terms.