Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a user-friendly assert that catches the NaNs #69

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

exaexa
Copy link
Contributor

@exaexa exaexa commented Jan 15, 2025

...before they cause a really weird error elsewhere.

This is simple and hopefully mergeable part taken out of #67 and #68 (this change is correspondingly removed from there)

...before they cause a really weird error elsewhere.
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.57%. Comparing base (dd9768e) to head (d65e802).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   72.56%   72.57%   +0.01%     
==========================================
  Files          71       71              
  Lines        2497     2498       +1     
==========================================
+ Hits         1812     1813       +1     
  Misses        685      685              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davibarreira davibarreira merged commit 1157ee5 into davibarreira:master Jan 15, 2025
5 checks passed
@davibarreira
Copy link
Owner

Thanks, @exaexa !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants