-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(dashmate)!: disable config auto render #1499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshenmic
requested review from
shumkov,
antouhou and
QuantumExplorer
as code owners
October 18, 2023 08:15
pshenmic
force-pushed
the
feat/dashmate-disable-auto-render
branch
from
October 18, 2023 18:21
1cf69e3
to
8bf1508
Compare
shumkov
requested changes
Oct 20, 2023
packages/dashmate/src/listr/tasks/setup/setupLocalPresetTaskFactory.js
Outdated
Show resolved
Hide resolved
shumkov
changed the title
feat(dashmate): disable config auto render
pref(dashmate): disable config auto render
Oct 23, 2023
shumkov
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update branch please it contains other changes
pshenmic
force-pushed
the
feat/dashmate-disable-auto-render
branch
from
October 23, 2023 11:59
6fec179
to
8371d76
Compare
pshenmic
changed the title
pref(dashmate): disable config auto render
perf(dashmate): disable config auto render
Oct 23, 2023
pshenmic
changed the title
perf(dashmate): disable config auto render
perf(dashmate)!: disable config auto render
Oct 23, 2023
Co-authored-by: Ivan Shumkov <[email protected]> Co-authored-by: QuantumExplorer <[email protected]>
shumkov
previously approved these changes
Oct 23, 2023
shumkov
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Disable config auto render on each dashmate command execution
More details:
#1181
What was done?
BaseCommand
ConfigBaseCommand
andGroupBaseCommand
resetNodeTask
setupRegularNodeTask
andsetupLocalNodeTask
dashmate config create
,dashmate config remove
anddashmate config set
commandsdashmate config
commandHow Has This Been Tested?
Locally
Breaking Changes
Dashmate does not auto render service configs on each command run
Checklist:
For repository code-owners and collaborators only