Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(dashmate)!: disable config auto render #1499

Merged
merged 20 commits into from
Oct 24, 2023

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Oct 18, 2023

Issue being fixed or feature implemented

Disable config auto render on each dashmate command execution

More details:
#1181

What was done?

  • Removed writing json config file from BaseCommand
  • Removed writing service configs from ConfigBaseCommand and GroupBaseCommand
  • Added json config writes in the end of resetNodeTask
  • Added json config + service configs write in the end of setupRegularNodeTask and setupLocalNodeTask
  • Added json config + service configs write in the dashmate config create, dashmate config remove and dashmate config set commands
  • Added service configs write in the dashmate config command

How Has This Been Tested?

Locally

Breaking Changes

Dashmate does not auto render service configs on each command run

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic self-assigned this Oct 18, 2023
@pshenmic pshenmic changed the base branch from master to v1.0-dev October 18, 2023 18:14
@pshenmic pshenmic force-pushed the feat/dashmate-disable-auto-render branch from 1cf69e3 to 8bf1508 Compare October 18, 2023 18:21
@pshenmic pshenmic added this to the v1.0.0 milestone Oct 18, 2023
@shumkov shumkov changed the title feat(dashmate): disable config auto render pref(dashmate): disable config auto render Oct 23, 2023
@shumkov shumkov changed the base branch from v1.0-dev to master October 23, 2023 07:14
@shumkov shumkov changed the base branch from master to v1.0-dev October 23, 2023 07:14
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update branch please it contains other changes

@pshenmic pshenmic changed the base branch from v1.0-dev to master October 23, 2023 11:54
@pshenmic pshenmic force-pushed the feat/dashmate-disable-auto-render branch from 6fec179 to 8371d76 Compare October 23, 2023 11:59
@pshenmic pshenmic changed the title pref(dashmate): disable config auto render perf(dashmate): disable config auto render Oct 23, 2023
@pshenmic pshenmic changed the title perf(dashmate): disable config auto render perf(dashmate)!: disable config auto render Oct 23, 2023
shumkov
shumkov previously approved these changes Oct 23, 2023
@pshenmic pshenmic merged commit 87fb68c into master Oct 24, 2023
10 checks passed
@pshenmic pshenmic deleted the feat/dashmate-disable-auto-render branch October 24, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants