Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate): disable service configs auto render #1181

Closed
pshenmic opened this issue Jun 21, 2023 · 1 comment
Closed

feat(dashmate): disable service configs auto render #1181

pshenmic opened this issue Jun 21, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pshenmic
Copy link
Collaborator

Expected Behavior

Service configs (dash.conf, config.toml, etc..) are updated and rerendered only when necessary, i.e when config was updated.

Current Behavior

Dashmate renders service configs on each command run and could produce unexpected results. It also decreases dashmate command start time.

Possible Solution

Remove writeServiceConfigs from BaseCommand and implement render in the neccessary places

Alternatives Considered

Additional Context

@pshenmic
Copy link
Collaborator Author

#1499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant