backport: merge bitcoin#23092, #23005, #24704, #24391, #25338, #25422, #25493, #26826, #26814, #26832, #27418, partial bitcoin#27254 (compat backports)

[kwvg]

Additional Information

• This PR originally included bitcoin#27378 but including it caused multiple tests to fail (build), even after adjusting timeout. It has been omitted instead.

  Test failures:

  feature_abortnode.py                               |   Failed  | 201 s
  feature_dip3_v19.py                                |   Failed  | 237 s
  feature_llmq_rotation.py                           |   Failed  | 54 s
  p2p_invalid_messages.py                            |   Failed  | 5 s
  rpc_bind.py --nonloopback                          |   Failed  | 63 s
  wallet_multiwallet.py --descriptors                |   Failed  | 79 s
  wallet_multiwallet.py --legacy-wallet              |   Failed  | 89 s
  
  ALL                                                |   Failed  | 8540 s (accumulated)
  

  feature_abortnode.py failure:

  dash@107cfae2b2b5:/src/dash$ ./test/functional/feature_abortnode.py
  2024-12-09T18:31:01.776000Z TestFramework (INFO): PRNG seed is: 6843309100291447752
  2024-12-09T18:31:01.776000Z TestFramework (INFO): Initializing test directory /tmp/dash_func_test_fcijb99n
  2024-12-09T18:31:02.802000Z TestFramework (INFO): Waiting for crash
  2024-12-09T18:34:23.026000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
      def is_node_stopped(self):
          """Checks whether the node has stopped.
  
          Returns True if the node has stopped. False otherwise.
          This method is responsible for freeing resources (self.process)."""
          if not self.running:
              return True
          return_code = self.process.poll()
          if return_code is None:
              return False
  
          # process has stopped. Assert that it didn't return an error code.
          assert return_code == 0, self._node_msg(
              "Node returned non-zero exit code (%d) when stopping" % return_code)
          self.running = False
          self.process = None
          self.rpc_connected = False
          self.rpc = None
          self.log.debug("Node stopped")
          return True
  '''
  2024-12-09T18:34:23.027000Z TestFramework (ERROR): Assertion failed
  Traceback (most recent call last):
    File "/src/dash/test/functional/test_framework/test_framework.py", line 161, in main
      self.run_test()
    File "/src/dash/./test/functional/feature_abortnode.py", line 44, in run_test
      self.nodes[0].wait_until_stopped(timeout=200)
    File "/src/dash/test/functional/test_framework/test_node.py", line 414, in wait_until_stopped
      wait_until_helper(self.is_node_stopped, timeout=timeout, timeout_factor=self.timeout_factor)
    File "/src/dash/test/functional/test_framework/util.py", line 287, in wait_until_helper
      raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
  AssertionError: Predicate ''''
      def is_node_stopped(self):
          """Checks whether the node has stopped.
  
          Returns True if the node has stopped. False otherwise.
          This method is responsible for freeing resources (self.process)."""
          if not self.running:
              return True
          return_code = self.process.poll()
          if return_code is None:
              return False
  
          # process has stopped. Assert that it didn't return an error code.
          assert return_code == 0, self._node_msg(
              "Node returned non-zero exit code (%d) when stopping" % return_code)
          self.running = False
          self.process = None
          self.rpc_connected = False
          self.rpc = None
          self.log.debug("Node stopped")
          return True
  ''' not true after 200.0 seconds
  2024-12-09T18:34:23.530000Z TestFramework (INFO): Stopping nodes
  2024-12-09T18:34:23.530000Z TestFramework (ERROR): Unexpected exception caught during shutdown
  Traceback (most recent call last):
    File "/src/dash/test/functional/test_framework/test_framework.py", line 341, in shutdown
      self.stop_nodes()
    File "/src/dash/test/functional/test_framework/test_framework.py", line 673, in stop_nodes
      node.stop_node(expected_stderr=expected_stderr, wait=wait, wait_until_stopped=False)
    File "/src/dash/test/functional/test_framework/test_node.py", line 368, in stop_node
      self.stop(wait=wait)
    File "/src/dash/test/functional/test_framework/coverage.py", line 49, in __call__
      return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
    File "/src/dash/test/functional/test_framework/authproxy.py", line 124, in __call__
      response, status = self._request('POST', self.__url.path, postdata.encode('utf-8'))
    File "/src/dash/test/functional/test_framework/authproxy.py", line 103, in _request
      return self._get_response()
    File "/src/dash/test/functional/test_framework/authproxy.py", line 162, in _get_response
      raise JSONRPCException(
  test_framework.authproxy.JSONRPCException: non-JSON HTTP response with '503 Service Unavailable' from server (-342)
  2024-12-09T18:34:23.531000Z TestFramework (WARNING): Not cleaning up dir /tmp/dash_func_test_fcijb99n
  2024-12-09T18:34:23.531000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/dash_func_test_fcijb99n/test_framework.log
  2024-12-09T18:34:23.531000Z TestFramework (ERROR):
  2024-12-09T18:34:23.531000Z TestFramework (ERROR): Hint: Call /src/dash/test/functional/combine_logs.py '/tmp/dash_func_test_fcijb99n' to consolidate all logs
  2024-12-09T18:34:23.531000Z TestFramework (ERROR):
  2024-12-09T18:34:23.531000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
  2024-12-09T18:34:23.531000Z TestFramework (ERROR): https://github.com/dashpay/dash/issues
  2024-12-09T18:34:23.531000Z TestFramework (ERROR):
  [node 1] Cleaning up leftover process
  [node 0] Cleaning up leftover process
  

• bitcoin#27254 has been partially backported to include a missing header to allow it to build.

  Compile error:

  In file included from ./util/system.h:19,
                 from util/system.cpp:7:
  ./compat/assumptions.h:49:22: error: 'size_t' was not declared in this scope; did you mean 'std::size_t'?
     49 | static_assert(sizeof(size_t) == 4 || sizeof(size_t) == 8, "size_t assumed to be 32-bit or 64-bit");
        |                      ^~~~~~
        |                      std::size_t
  In file included from /usr/include/c++/11/limits:42,
                 from ./compat/assumptions.h:11,
                 from ./util/system.h:19,
                 from util/system.cpp:7:
  /usr/include/x86_64-linux-gnu/c++/11/bits/c++config.h:280:33: note: 'std::size_t' declared here
    280 |   typedef __SIZE_TYPE__         size_t;
        |                                 ^~~~~~
  

• GitLab job failures as of 2339ae6, for linux64-build (source), linux64_cxx20-build (source) and linux64_sqlite-build (source) are not related to failures in compilation or unit tests but are to do with reaching the artifact limit. Resolved with dash#6487, thanks Udjin!

Breaking Changes

None expected.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas (note: N/A)
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

This pull request has conflicts, please rebase.

[UdjinM6]

utACK 2ab561d

[PastaPastaPasta]

utACK 2ab561d