ci: specify exact paths and better names for gitlab artifacts #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
ci_exact_paths
branch
from
453a4cb to
9ff2c6c
Compare
UdjinM6
force-pushed
the
ci_exact_paths
branch
3 times, most recently
from
e3d0fa6 to
f5ef582
Compare
|
This pull request has conflicts, please rebase. |
UdjinM6
force-pushed
the
ci_exact_paths
branch
from
f5ef582 to
e862229
Compare
UdjinM6
force-pushed
the
ci_exact_paths
branch
from
e862229 to
9d9e54f
Compare
5 tasks
UdjinM6
force-pushed
the
ci_exact_paths
branch
from
9d9e54f to
b48d713
Compare
PastaPastaPasta
added a commit
that referenced
this pull request
Dec 14, 2024
…downloaded files a191c09 ci: better names for artifacts (UdjinM6) 3984a49 ci: exclude `*.a` and `*.o` files from artifacts (UdjinM6) Pull request description: ## Issue being fixed or feature implemented We include too many files in artifacts on `build` ci step, some of which (`*.a` and `*.o`) can be pretty heavy. This was ok-ish for some time but artifacts size is getting closer to the limit and even starts to cause issues, see #6462. ## What was done? Exclude `*.a` and `*.o` files from artifacts. Also, change artifacts name to make it easier to distinguish them when you get a few of them from the same pipeline - `build-arm-linux.zip`, `build-linux64.zip` etc. instead of `binaries.zip`, `binaries (1).zip` etc., same for `depends`. A simpler alternative to #6483 As a result the size of tsan artifacts for example is down from 508MB in 6462 to 154MB in this PR. ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK a191c09 kwvg: utACK a191c09 Tree-SHA512: eb3029c95a11546958d34ad284f4eb600b6113a2cabb885f7381afd16696f51da7eaf1677a1cdfec53311838c6845bb1c2c7c98f0ae112294b33f6ab6c66c500
|
This pull request has conflicts, please rebase. |
|
superseded by #6487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We include too many files in artifacts on
buildci step, some of which (*.aand*.o) can be pretty heavy. This was ok-ish for some time but artifacts size is getting closer to the limit and even starts to cause issues, see #6462.What was done?
Specify exact files that are needed for functional tests (
testci step) and for users who wants to get binaries from artifacts. Also, change artifacts name to make it easier to distinguish them when you get a few of them from the same pipeline -build-arm-linux.zip,build-linux64.zipetc. instead ofbinaries.zip,binaries (1).zipetc., same fordepends.As a result the size of tsan artifacts for example is down from 508MB in 6462 to 116MB in this PR (or 78MB if we exclude logs 47ae9a4).
How Has This Been Tested?
Breaking Changes
Checklist: