Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Restrict python-rt version #2371

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

kamil-certat
Copy link
Contributor

The python-rt in version 3 introduced some small backward incompatible changes.

Related changes are tracked in #2367

@kamil-certat kamil-certat requested a review from sebix May 25, 2023 14:36
@kamil-certat kamil-certat self-assigned this May 25, 2023
Copy link
Member

@sebix sebix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a small note in docs/user/bots.rst too?

If the user has rt 3.0.0 installed, the bot will just fail. by checking the rt version in the bot, the error message would be more precise (the mongodb output bot does this for example)

@sebix sebix added this to the 3.2.0 milestone May 31, 2023
docs/user/bots.rst Outdated Show resolved Hide resolved
docs/user/bots.rst Outdated Show resolved Hide resolved
kamil-certat and others added 2 commits June 1, 2023 15:14
@sebix sebix merged commit 99a632f into certtools:develop Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants