Skip to content

Commit

Permalink
FIX: Restrict python-rt version (#2371)
Browse files Browse the repository at this point in the history
* FIX: Restrict python-rt version

* DOC: document supportet rt library

* Update docs/user/bots.rst

Co-authored-by: Sebastian <[email protected]>
  • Loading branch information
kamil-certat and sebix authored Jun 7, 2023
1 parent 3be2460 commit 99a632f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ CHANGELOG
### Bots

#### Collectors
- `intelmq.bots.collector.rt`: restrict `python-rt` to be below version 3.0 due to introduced breaking changes.

#### Parsers
- `intelmq.bots.parsers.shadowserver._config`:
Expand Down
6 changes: 5 additions & 1 deletion docs/user/bots.rst
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,11 @@ Request Tracker
* `cache (redis db):` none
* `description:` Request Tracker Collector fetches attachments from an RTIR instance.

You need the rt-library >= 1.9 from nic.cz, available via `pypi <https://pypi.org/project/rt/>`_: `pip3 install rt`
You need the rt-library >= 1.9 and < 3.0 from nic.cz, available via `pypi <https://pypi.org/project/rt/>`_: `pip3 install 'rt<3'`

.. warning::

At the moment, the bot only supports `python-rt` versions below 3.0.

This rt bot will connect to RT and inspect the given `search_queue` for tickets matching all criteria in `search_*`,
Any matches will be inspected. For each match, all (RT-) attachments of the matching RT tickets are iterated over and within this loop, the first matching filename in the attachment is processed.
Expand Down
2 changes: 1 addition & 1 deletion intelmq/bots/collectors/rt/REQUIREMENTS.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: 2016 Sebastian Wagner
# SPDX-License-Identifier: AGPL-3.0-or-later

rt>=1.0.9
rt<3.0.0,>=1.0.9

0 comments on commit 99a632f

Please sign in to comment.