bigint: Rename PartialModulus to Modulus, Modulus to OwnedModulusWithOne. #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally we only had `Modulus`. Then we had a need for a temporary `Modulus` without `oneRR` so we created `PartialModulus`. However, there is really nothing "partial" about them. So, improve the naming by renaming `PartialModulus` to `Modulus` and `Modulus` to `OwnedModulusWithOne`. In the future we may refactor things further to separate the ownership aspect from the "has oneRR" aspect. Instead of just doing a straightforward rename, take this opportunity to refactor the code so that it uses the new `Modulus` whenever `oneRR()` isn't used. This eliminates the duplication of the APIs of the two modulus types, and the duplication of `elem_mul` and `elem_mul_`.
Codecov Report
@@ Coverage Diff @@
## main #1796 +/- ##
==========================================
+ Coverage 96.00% 96.02% +0.01%
==========================================
Files 137 137
Lines 20796 20789 -7
Branches 226 226
==========================================
- Hits 19966 19962 -4
+ Misses 792 790 -2
+ Partials 38 37 -1
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we only had
Modulus. Then we had a need for a temporaryModuluswithoutoneRRso we createdPartialModulus. However, there is really nothing "partial" about them. So, improve the naming by renamingPartialModulustoModulusandModulustoOwnedModulusWithOne. In the future we may refactor things further to separate the ownership aspect from the "has oneRR" aspect.Instead of just doing a straightforward rename, take this opportunity to refactor the code so that it uses the new
ModuluswheneveroneRR()isn't used. This eliminates the duplication of the APIs of the two modulus types, and the duplication ofelem_mulandelem_mul_.