-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pose_initializer): add a method type to the /localization/initialize
service.
#7048
feat(pose_initializer): add a method type to the /localization/initialize
service.
#7048
Conversation
…specs Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
/localization/initialize
service./localization/initialize
service.
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp
Outdated
Show resolved
Hide resolved
…lizer_core.cpp Co-authored-by: Ryohsuke Mitsudome <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for default_ad_api package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the feature is fine. 👏
Since the method of setting the initial position via CLI is useful, how about writing it in the README of pose_initializer?
For example, a chapter like Direct initial position set via CLI
.
Thank you. |
Yes, I'm sorry. |
Signed-off-by: Yamato Ando <[email protected]>
@KYabuuchi I added some descriptions to initialize pose via CLI |
Signed-off-by: Yamato Ando <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YamatoAndo Thank you!
LGTM 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Me
…alize` service. (autowarefoundation#7048) * change message type of InitializeLocalization in component_interface_specs Signed-off-by: Yamato Ando <[email protected]> * change message type of InitializeLocalizaion in pose_initializer Signed-off-by: Yamato Ando <[email protected]> * modify readme Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * delete redundant line Signed-off-by: Yamato Ando <[email protected]> * fix typo Signed-off-by: Yamato Ando <[email protected]> * Update localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp Co-authored-by: Ryohsuke Mitsudome <[email protected]> * add description in readme Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * add bash Signed-off-by: Yamato Ando <[email protected]> --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <[email protected]>
…alize` service. (autowarefoundation#7048) * change message type of InitializeLocalization in component_interface_specs Signed-off-by: Yamato Ando <[email protected]> * change message type of InitializeLocalizaion in pose_initializer Signed-off-by: Yamato Ando <[email protected]> * modify readme Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * delete redundant line Signed-off-by: Yamato Ando <[email protected]> * fix typo Signed-off-by: Yamato Ando <[email protected]> * Update localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp Co-authored-by: Ryohsuke Mitsudome <[email protected]> * add description in readme Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * add bash Signed-off-by: Yamato Ando <[email protected]> --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <[email protected]>
…alize` service. (#7048) * change message type of InitializeLocalization in component_interface_specs Signed-off-by: Yamato Ando <[email protected]> * change message type of InitializeLocalizaion in pose_initializer Signed-off-by: Yamato Ando <[email protected]> * modify readme Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * delete redundant line Signed-off-by: Yamato Ando <[email protected]> * fix typo Signed-off-by: Yamato Ando <[email protected]> * Update localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp Co-authored-by: Ryohsuke Mitsudome <[email protected]> * add description in readme Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * add bash Signed-off-by: Yamato Ando <[email protected]> --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Description
I have added the capability to directly initialize by the input pose of the
/localization/initialize
service.To facilitate this, a new service message is being defined tier4/tier4_autoware_msgs#121, and I have changed service message type of
/localization/initialize
autoware_adapi_v1_msgs::srv::InitializeLocalization
->tier4_localization_msgs::srv::InitializeLocalization
.Along with that I have modified following packages
Related links
Tests performed
The initial position is automatically estimated using the GNSS pose.
The initial position is automatically estimated using the GNSS pose.
The initial position is automatically estimated using the input pose.
The initial position is set directly by the input pose.
Notes for reviewers
This PR should be merged after tier4/tier4_autoware_msgs#121.
Otherwise, the build will fail, and the GitHub CI will not pass.
And this PR should be merged with tier4/tier4_ad_api_adaptor#112 at the same time.
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.