add dependencies, change SHA module name for Linux systems #1
Conversation
There was a problem hiding this comment.
The commit description could be slightly more verbatim. Please add a signed off by line (git commit does this for you with option -s) so it is clear that this is your code and you are happy with publishing it under an open license.
A quick git commit --amend should do the job for you.
| This script depends on the Digest::SHA and the Term::Readkey perl modules. | ||
| On Debian-based systems (Debian, Ubuntu, Mint etc.) they can be installed by | ||
|
|
||
| sudo apt install libdigest-sha-perl libterm-readkey-perl |
There was a problem hiding this comment.
Fine. I wrote this on a Mac and had these modules already installed (I don't know if I did this in the past manually or they were preinstalled.
There is also a perl specific way to install modules:
perl -M CPAN -e shell
install Digest::SHA
install Term::ReadKey
That should work universally. But your suggestions are fine if you want to worry just about your distribution handling updates.
| @@ -9,7 +9,7 @@ | |||
|
|
|||
|
|
|||
| # Functional style | |||
| use Digest::SHA1 qw(sha1 sha1_hex sha1_base64); | |||
| use Digest::SHA qw(sha1 sha1_hex sha1_base64); | |||
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| while(1) { | |||
| print "Password to check:\n"; | |||
| ReadMode ( 'noecho' ); | |||
| # ReadMode ( 'noecho' ); | |||
There was a problem hiding this comment.
This I don't like. What did you turn off the no echo?
Hi Robert,
thank you very much for that useful little script!
Using it on Mint 19 (Ubuntu-like) I had to figure out the required dependency packages and change the Digest::SHA module name. Maybe you would like to include these changes?
Michael