Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move ts_config src to outputted JsInfo.sources #761

Merged
merged 1 commit into from
Jan 14, 2025
Merged

refactor: move ts_config src to outputted JsInfo.sources #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ts/private/ts_config.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ def _ts_config_impl(ctx):
if TsConfigInfo in dep:
transitive_deps.append(dep[TsConfigInfo].deps)

transitive_sources = js_lib_helpers.gather_transitive_sources([], ctx.attr.deps)
transitive_sources = js_lib_helpers.gather_transitive_sources(files, ctx.attr.deps)
jbedard marked this conversation as resolved.
Show resolved Hide resolved

transitive_types = js_lib_helpers.gather_transitive_types(files, ctx.attr.deps)
transitive_types = js_lib_helpers.gather_transitive_types([], ctx.attr.deps)

npm_sources = js_lib_helpers.gather_npm_sources(
srcs = [],
Expand Down Expand Up @@ -81,8 +81,8 @@ def _ts_config_impl(ctx):
# provide tsconfig.json file via `types` and not `sources` since they are only needed
# for downstream ts_project rules and not in downstream runtime binary rules
target = ctx.label,
sources = depset(),
types = files_depset,
sources = files_depset,
types = depset(),
transitive_sources = transitive_sources,
transitive_types = transitive_types,
npm_sources = npm_sources,
Expand Down
Loading