Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move ts_config src to outputted JsInfo.sources #761

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jan 10, 2025

The JsInfo.[transitive_]sources from ts_config should contain the sources required to compile, while JsInfo.[transitive_]types should contain any additional files required to type-check.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Jan 10, 2025

Test

All tests were cache hits

159 tests (100.0%) were fully cached saving 15s.


Buildifier      Format

@jbedard jbedard marked this pull request as ready for review January 10, 2025 20:08
Copy link

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jbedard jbedard merged commit 7dc264b into aspect-build:main Jan 14, 2025
20 checks passed
@jbedard jbedard deleted the tsconfig_json_types branch January 14, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants