Umoci unpack fix #4168
Merged
Umoci unpack fix #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AdamSimpson Looks like I cant add you as a reviewer in the github ui, but I'd like to get your approval here to make sure the work you've done is properly credited and that this works for you |
|
Awesome, that looks great! |
ikaneshiro
force-pushed
the
umoci_unpack_fix
branch
from
120c6d2 to
75a3d96
Compare
ikaneshiro
force-pushed
the
umoci_unpack_fix
branch
from
75a3d96 to
469a61f
Compare
This change creates two small files to split oci layer unpacking into a new function that allows for different behavior based on platform. NOTE: umoci v0.4.2 is used to prevent an a dependency issue with github.com/opencontainers/runtime-spec v1.0.0 not being backwards compatable Update apptainer#3921 to most recent master
ikaneshiro
force-pushed
the
umoci_unpack_fix
branch
from
469a61f to
d4d0498
Compare
WestleyK
approved these changes
Aug 14, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
This PR rebases the work done by @AdamSimpson in #3921 to a more current branch and applies his suggestion of having separate, platform dependent, implementations of layer unpacking.
NOTE: umoci v0.4.2 is used to prevent an a dependency issue with github.com/opencontainers/runtime-spec v1.0.0 having backwards incompatibilities
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make testallAttn: @singularity-maintainers