Umoci unpack #3921
Closed
Umoci unpack #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendor using correct image tag
|
It looks like umoci is not going to build on darwin, as there are linux only files. Perhaps |
ikaneshiro
added a commit
to ikaneshiro/singularity
that referenced
this pull request
Aug 8, 2019
This change creates a small package to split oci layer unpacking into a new function that allows for platform dependent builds. NOTE: umoci v0.4.2 is used to prevent an a dependency issue with github.com/opencontainers/runtime-spec v1.0.0 not being backwards compatable Update apptainer#3921 to most recent master
ikaneshiro
added a commit
to ikaneshiro/singularity
that referenced
this pull request
Aug 9, 2019
This change creates two small files to split oci layer unpacking into a new function that allows for different behavior based on platform. NOTE: umoci v0.4.2 is used to prevent an a dependency issue with github.com/opencontainers/runtime-spec v1.0.0 not being backwards compatable Update apptainer#3921 to most recent master
ikaneshiro
added a commit
to ikaneshiro/singularity
that referenced
this pull request
Aug 9, 2019
This change creates two small files to split oci layer unpacking into a new function that allows for different behavior based on platform. NOTE: umoci v0.4.2 is used to prevent an a dependency issue with github.com/opencontainers/runtime-spec v1.0.0 not being backwards compatable Update apptainer#3921 to most recent master
ikaneshiro
added a commit
to ikaneshiro/singularity
that referenced
this pull request
Aug 9, 2019
This change creates two small files to split oci layer unpacking into a new function that allows for different behavior based on platform. NOTE: umoci v0.4.2 is used to prevent an a dependency issue with github.com/opencontainers/runtime-spec v1.0.0 not being backwards compatable Update apptainer#3921 to most recent master
Merged
ikaneshiro
added a commit
to ikaneshiro/singularity
that referenced
this pull request
Aug 14, 2019
This change creates two small files to split oci layer unpacking into a new function that allows for different behavior based on platform. NOTE: umoci v0.4.2 is used to prevent an a dependency issue with github.com/opencontainers/runtime-spec v1.0.0 not being backwards compatable Update apptainer#3921 to most recent master
ikaneshiro
added a commit
to ikaneshiro/singularity
that referenced
this pull request
Aug 14, 2019
This change creates two small files to split oci layer unpacking into a new function that allows for different behavior based on platform. NOTE: umoci v0.4.2 is used to prevent an a dependency issue with github.com/opencontainers/runtime-spec v1.0.0 not being backwards compatable Update apptainer#3921 to most recent master
ikaneshiro
added a commit
to ikaneshiro/singularity
that referenced
this pull request
Aug 14, 2019
This change creates two small files to split oci layer unpacking into a new function that allows for different behavior based on platform. NOTE: umoci v0.4.2 is used to prevent an a dependency issue with github.com/opencontainers/runtime-spec v1.0.0 not being backwards compatable Update apptainer#3921 to most recent master
|
Closing as #4168 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
This is a first stab at moving from image-tools to umoci for OCI unpacking.
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make testallAttn: @singularity-maintainers