Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed bluebird #207

Closed
wants to merge 1 commit into from
Closed

Conversation

darseen
Copy link
Contributor

@darseen darseen commented Jan 15, 2024

Pull Request: Removed Bluebird Dependency

Changes Made:

  • Removed the Bluebird library and implementation from the codebase as it's considered obsolete.
  • This change can make the code lighter and potentially faster to load, especially in a browser context.
  • Updated methods to use native JavaScript promises instead of Bluebird, as recommended by the Bluebird GitHub page.
  • The codebase wasn't heavily dependent on Bluebird, making the removal straightforward.

Additional Information:

  • The Bluebird GitHub page recommends the usage of native promises if at all possible, and this change aligns with that recommendation.
  • The codebase didn't utilize any specific Bluebird methods, further justifying the removal of the dependency.
  • The bearerToken method, mentioned in the JSDocs that it returns a Bluebird Promise, yet it was using the native JavaScript Promise.

Testing:

  • All tests have passed.
  • Locally tested the build, specifically fetching flights, and verified that it works as expected.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant