Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Build Failure After Removing Bluebird Dependency #209

Closed
darseen opened this issue Jan 16, 2024 · 0 comments · Fixed by #211
Closed

Resolve Build Failure After Removing Bluebird Dependency #209

darseen opened this issue Jan 16, 2024 · 0 comments · Fixed by #211

Comments

@darseen
Copy link
Contributor

darseen commented Jan 16, 2024

Issue Description:

The recent pull request (PR: #207) titled "Removed Bluebird Dependency" aimed to eliminate the usage of the Bluebird library, making the codebase lighter and potentially faster. However, the build checks for this pull request have failed due to permission issues when trying to access the remote repository.

Changes Made:

  • Removed the Bluebird library and implementation from the codebase.
  • Updated methods to use native JavaScript promises instead of Bluebird, following the recommendation on the Bluebird GitHub page.

Additional Information:

  • The Bluebird GitHub page suggests using native promises if at all possible, and this change aligns with that recommendation.
  • The codebase didn't utilize any specific Bluebird methods, further justifying the removal of the dependency.
  • The bearerToken method, documented to return a Bluebird Promise in JSDocs, yet it was using the native JavaScript Promise.

Build Failure Details:

The build failure occurred due to permission issues while accessing the remote repository. The following error messages were displayed in the logs:

remote: Permission to amadeus4dev/amadeus-node.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/amadeus4dev/amadeus-node.git/': The requested URL returned error: 403
Error: The deploy step encountered an error: The process '/usr/bin/git' failed with exit code 128

Versions

[What version of Node/NPM are you running? What Operating System are you on?]

  • Node: 20.10.0
  • npm: 10.2.3
  • Operating System: Ubuntu 22.04.3 LTS

Checklist

Please make sure you checked the following:

  • Are you running any of the current Node LTS versions? Yes
  • Did you download the latest version of this library? Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant