Skip to content

feat(combobox): controlled combobox open state #2774

feat(combobox): controlled combobox open state

feat(combobox): controlled combobox open state #2774

Triggered via pull request March 15, 2024 15:08
Status Success
Total duration 6m 0s
Artifacts

quality.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

17 warnings
Typecheck
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Accessibility
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Lint: documentation/helpers/FAQ/Question.tsx#L38
Classnames 'h-sz-20, w-sz-20' could be replaced by the 'size-sz-20' shorthand!
Lint: packages/components/checkbox/src/CheckboxIndicator.tsx#L13
Classnames 'h-full, w-full' could be replaced by the 'size-full' shorthand!
Lint: packages/components/checkbox/src/CheckboxInput.styles.ts#L4
Classnames 'h-sz-24, w-sz-24' could be replaced by the 'size-sz-24' shorthand!
Lint: packages/components/combobox/src/ComboboxClearButton.tsx#L19
Expected an assignment or function call and instead saw an expression
Lint: packages/components/combobox/src/ComboboxContext.tsx#L131
Arrow function has too many lines (209). Maximum allowed is 200
Lint: packages/components/combobox/src/ComboboxContext.tsx#L131
Arrow function has a complexity of 12. Maximum allowed is 8
Lint: packages/components/combobox/src/ComboboxContext.tsx#L210
React Hook useEffect has missing dependencies: 'comboboxValue', 'itemsMap', and 'multiple'. Either include them or remove the dependency array. You can also replace multiple useState variables with useReducer if 'setSelectedItem' needs the current value of 'itemsMap'
Lint: packages/components/combobox/src/ComboboxContext.tsx#L210
React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked
Lint: packages/components/combobox/src/ComboboxContext.tsx#L227
React Hook useEffect has a missing dependency: 'autoFilter'. Either include it or remove the dependency array. If 'setFilteredItems' needs the current value of 'autoFilter', you can also switch to useReducer instead of useState and read 'autoFilter' in the reducer
Lint: packages/components/combobox/src/ComboboxContext.tsx#L231
Method 'stateReducer' has a complexity of 12. Maximum allowed is 8
Deploy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Deploy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Visual testing
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.