Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combobox): controlled combobox open state #1970

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Powerplex
Copy link
Contributor

@Powerplex Powerplex commented Mar 15, 2024

TASK: #1963

Description, Motivation and Context

  • open and onOpenChange props to control the open state of the combobox from outside.

Types of changes

  • ✨ New feature (non-breaking change which adds functionality)

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (0c4976b) to head (72cc803).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1970   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         746      746           
  Lines        5674     5678    +4     
  Branches     1990     1992    +2     
=======================================
+ Hits         5562     5566    +4     
  Misses        112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Powerplex Powerplex merged commit 4a9b25a into main Mar 15, 2024
9 of 10 checks passed
@Powerplex Powerplex deleted the combobox-controlled-open-state branch March 15, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant