Feat/implementation authority #70
Conversation
| #[storage] | ||
| struct Storage { | ||
| current_version: Version, | ||
| ///TODO: Consider making this enumerable to enumerate all available implementations |
There was a problem hiding this comment.
Making Version Enumerable?
There's not a finite set of versions so I think struct type is better
There was a problem hiding this comment.
Maybe add comment //Map<VersionPacked, TREXImplementationsStore> for readability
There was a problem hiding this comment.
My comment was not sufficient to express my intention, I was trying to meant using EnumerableMap to list all the available versions stored in the contract. Currently only way to fetch all versions is querying through events
There was a problem hiding this comment.
Ok I agree it could be useful. This would potentially requires using an unique sequential identifier for each version to be able to quickly iterate over all existing versions
| self._use_trex_version(version); | ||
| } | ||
|
|
||
| fn upgrade_trex_suite(ref self: ContractState, token: ContractAddress, version: Version) { |
There was a problem hiding this comment.
so upgrade_trex_suite replace changeImplementationAuthority right
There was a problem hiding this comment.
So there's not a single reference contract and potential auxiliary authority contracts?
Instead, there's a single authority contract that keep track of the current version and the list of possible versions.
The owner can call upgrade_trex_suite to any versions
There was a problem hiding this comment.
Yes exactly, as far as I see auxiliary authorities can only use versions stored in reference contract. This behaviour mimics it without having multiple contracts. I see no need in having multiple contracts, unlike solidity we dont have proxies that queries implementation authority with same selector like get_ctr_implementation() etc... on each call
higher order bits should be zeros at this point so it should be okay to not mask Co-authored-by: Julio <[email protected]>
No description provided.