Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation Authority + IA Factory + propogation of the logic where it requires #68

Open
EgeCaner opened this issue Jan 14, 2025 · 1 comment · May be fixed by #70
Open

Implementation Authority + IA Factory + propogation of the logic where it requires #68

EgeCaner opened this issue Jan 14, 2025 · 1 comment · May be fixed by #70
Assignees
@EgeCaner

Comments

@EgeCaner
Copy link
Collaborator

No description provided.

@EgeCaner EgeCaner self-assigned this Jan 14, 2025
@EgeCaner
Copy link
Collaborator Author

IA Factory not needed.

Blocker: due to usage of get_class_hash_at_syscall sierra 1.7.0 is required. Its been released and expected to be available with next release of scarb & snforge.

Till then for sake of not blocking the development, ImplementationAuthority will be commented out in lib.cairo and testing will proceed with mocking calls to it. As soon as it is ready to use mock_calls gonna removed and replaced with original contract.

@EgeCaner EgeCaner linked a pull request Jan 16, 2025 that will close this issue
Feat/implementation authority #70
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EgeCaner EgeCaner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/implementation authority NethermindEth/erc3643_starknet
1 participant
@EgeCaner