Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oft-solana): don't create multisig if no additional minters #1170

Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat(oft-solana): don't create multisig if no additional minters #1170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions examples/oft-solana/tasks/solana/createOFT.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ task('lz:oft:solana:create', 'Mints new SPL Token and creates new OFT Store acco
uri,
computeUnitPriceScaleFactor,
}: CreateOFTTaskArgs) => {
const isMABA = !!mintStr
const isMABA = !!mintStr // the difference between MABA and OFT Adapter is that MABA uses mint/burn mechanism whereas OFT Adapter uses lock/unlock mechanism
if (tokenProgramStr !== TOKEN_PROGRAM_ID.toBase58() && !isMABA) {
throw new Error('Non-Mint-And-Burn-Adapter does not support custom token programs')
}
Expand Down Expand Up @@ -185,21 +185,27 @@ task('lz:oft:solana:create', 'Mints new SPL Token and creates new OFT Store acco
}

const additionalMinters = additionalMintersAsStrings?.map((minter) => new PublicKey(minter)) ?? []
const mintAuthorityPublicKey = await createMintAuthorityMultisig(
connection,
umi,
eid,
umiWalletSigner,
toWeb3JsPublicKey(oftStorePda),
toWeb3JsPublicKey(tokenProgramId), // Only configurable for MABA
additionalMinters,
computeUnitPriceScaleFactor
)
console.log(`created SPL multisig @ ${mintAuthorityPublicKey.toBase58()}`)
await checkMultisigSigners(connection, mintAuthorityPublicKey, [
toWeb3JsPublicKey(oftStorePda),
...additionalMinters,
])

let mintAuthorityPublicKey: PublicKey = toWeb3JsPublicKey(oftStorePda) // we default to the OFT Store as the Mint Authority when there are no additional minters

if (additionalMintersAsStrings) {
// we only need a multisig when we have additional minters
mintAuthorityPublicKey = await createMintAuthorityMultisig(
connection,
umi,
eid,
umiWalletSigner,
toWeb3JsPublicKey(oftStorePda),
toWeb3JsPublicKey(tokenProgramId), // Only configurable for MABA
additionalMinters,
computeUnitPriceScaleFactor
)
console.log(`created SPL multisig @ ${mintAuthorityPublicKey.toBase58()}`)
await checkMultisigSigners(connection, mintAuthorityPublicKey, [
toWeb3JsPublicKey(oftStorePda),
...additionalMinters,
])
}

const mint = isMABA
? createNoopSigner(publicKey(mintStr))
Expand Down
Loading