Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oft-solana): don't create multisig if no additional minters #1170

Merged

Conversation

nazreen
Copy link
Contributor

@nazreen nazreen commented Jan 15, 2025

To test:

LZ_ENABLE_SOLANA_OFT_EXAMPLE=1 LAYERZERO_EXAMPLES_REPOSITORY_REF=#nazreen/oft-solana/rm-unnecessary-multisig-creation npx create-lz-oapp@latest

Test results:

When: no additional minters, Mint Authority is OFT Store
Mint: https://solscan.io/account/LbLqBcGtLQ55X13XWM35FS1rG3v1kdH3amXa9MWqxqs?cluster=devnet
Multisig: not created
Successful cross chain transfers:

When: additional minters provided, Mint Authority is Multisig
Mint: https://solscan.io/token/2H1PMNrahdQjZMpXfv7fdaFyuQjnJXHh7yAwxRqe2Zvc?cluster=devnet
Multisig: https://solscan.io/account/6qM5aYWRuLg6PLmgrJE7bbrYuNoBPg6p6ZxDYHU2Mk8q?cluster=devnet
Successful cross chain transfers:

@nazreen nazreen marked this pull request as ready for review January 15, 2025 11:49
@ryandgoulding
Copy link
Contributor

I am not quite sure about this. We had centralized on using MS as mint authority across this OFT reference. Do you know of any issues @ziming-zung

@ryandgoulding
Copy link
Contributor

Per offline discussion:

Yes, the code for signing works for both cases:
1.	When the mint authority is the OFTStore itself.
2.	When the mint authority is a multisig (1 of N) that includes the OFTStore as one of the signers.

@ryandgoulding ryandgoulding merged commit a8eb5db into main Jan 17, 2025
7 checks passed
@ryandgoulding ryandgoulding deleted the nazreen/oft-solana/rm-unnecessary-multisig-creation branch January 17, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants