-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new constructor for all Krylov solvers #947
Merged
amontoison
merged 11 commits into
JuliaSmoothOptimizers:main
from
amontoison:oceananigans
Jan 17, 2025
Merged
Add a new constructor for all Krylov solvers #947
amontoison
merged 11 commits into
JuliaSmoothOptimizers:main
from
amontoison:oceananigans
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
==========================================
- Coverage 94.68% 93.19% -1.49%
==========================================
Files 45 46 +1
Lines 8027 9181 +1154
==========================================
+ Hits 7600 8556 +956
- Misses 427 625 +198 ☔ View full report in Codecov by Sentry. |
amontoison
force-pushed
the
oceananigans
branch
from
January 17, 2025 18:37
2f0935c
to
9baae40
Compare
amontoison
merged commit Jan 17, 2025
a2ccdaf
into
JuliaSmoothOptimizers:main
31 of 35 checks passed
This was referenced Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #948
Needed for CliMA/Oceananigans.jl#4041.
A more generic constructor for our
KrylovSolvers
is required to support custom vector types.I was aware of this limitation, but addressing it requires significant work, as a new workspace constructor must be implemented manually for each Krylov solver.
To resolve the issue, I created a new constructor that takes a single argument (a
KrylovConstructor
or aBlockKrylovConstructor
).The
KrylovConstructor
encapsulates (custom) vectors on which we can applysimilar
to create the necessary workspace.Since some Krylov solvers, such as least-squares and least-norm solvers, require vectors of varying lengths that cannot be determined / created solely from the right-hand side vector
b
, only the in-place version of the Krylov method can be used in such cases.The corresponding
KrylovSolver
is created with aKrylovConstructor
.cc @michel2323