Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CGLS with shifts on rectangular systems #948

Closed
amontoison opened this issue Jan 17, 2025 · 1 comment · Fixed by #947
Closed

Test CGLS with shifts on rectangular systems #948

amontoison opened this issue Jan 17, 2025 · 1 comment · Fixed by #947
Assignees

Comments

@amontoison
Copy link
Member

@tmigot
I found that the size of the vectors in the workspace are not correct:
https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/main/src/krylov_solvers.jl#L1227-L1231

I will fix it in #947.
Did you never tested your solver on least-squares problems?

@amontoison
Copy link
Member Author

Update: The name of the variables in the workspace were just wrong.
I fixed it in #947 and also removed the allocation by default of the additional vector needed for a preconditioner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants