-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SLURM worker startup more robust and provide more feedback #200
Conversation
Using append! for job_output_template appends it character-wise, causing failure.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also fine with this 👍
Good to merge from my side (I'm looking into ElasticManager next, following advice from @JBlaschke ). |
Should we cut a release on this, or do you have more to do before that? |
Thanks, yes. I have some people who need to use this, I think it's good for now. |
Merci @kescobo ! |
Builds on top of #199.
Before (but with fix in #199):
After: