Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SlurmManager launch #199

Closed
wants to merge 1 commit into from
Closed

Fix SlurmManager launch #199

wants to merge 1 commit into from

Conversation

oschulz
Copy link
Contributor

@oschulz oschulz commented Apr 19, 2024

Using append! for job_output_template appends it character-wise, causing failure. Need to use push!.

@oschulz
Fix SlurmManager launch
815a3bf 
Using append! for job_output_template appends it character-wise, causing failure.
@oschulz oschulz mentioned this pull request Apr 19, 2024
Merged
kescobo
kescobo approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@kescobo kescobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/slurm.jl Show resolved Hide resolved
@kescobo
Copy link
Collaborator

kescobo commented Apr 19, 2024

Is there a compelling reason to merge this before #200, rather than just closing this and merging the other?

@oschulz
Copy link
Contributor Author

oschulz commented Apr 19, 2024

Thanks @kescobo and @Moelf ! The test failures are unrelated, I think.

@oschulz
Copy link
Contributor Author

oschulz commented Apr 19, 2024

Is there a compelling reason to merge this before #200, rather than just closing this and merging the other?

No, I just wanted to keep the little fix and the improvements separate for review purposes.

Closing this since included in #200.

@oschulz oschulz closed this Apr 19, 2024
@kescobo
Copy link
Collaborator

kescobo commented Apr 19, 2024

Yeah, testing is not in a great state right now. #105

@oschulz oschulz deleted the slurm-fix branch April 19, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moelf Moelf Moelf approved these changes

@kescobo kescobo kescobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oschulz @kescobo @Moelf