Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Test With Different Decimals #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Live Test With Different Decimals #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/deploy/single/04_DeployAccountantWithRateProviders.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ contract DeployAccountantWithRateProviders is BaseScript {
require(config.base != address(0), "base address must not be zero");
require(config.allowedExchangeRateChangeUpper > 1e4, "allowedExchangeRateChangeUpper");
require(config.allowedExchangeRateChangeUpper <= 1.003e4, "allowedExchangeRateChangeUpper upper bound");
require(config.allowedExchangeRateChangeLower < 1e4, "allowedExchangeRateChangeLower");
require(config.allowedExchangeRateChangeLower <= 1e4, "allowedExchangeRateChangeLower");
require(config.allowedExchangeRateChangeLower >= 0.997e4, "allowedExchangeRateChangeLower lower bound");
require(config.minimumUpdateDelayInSeconds >= 3600, "minimumUpdateDelayInSeconds");
require(config.managementFee < 1e4, "managementFee");
Expand Down
51 changes: 39 additions & 12 deletions test/LiveDeploy.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,12 @@ contract LiveDeploy is ForkTest, DeployAll {

depositAmount = bound(depositAmount, 0.5e18, 10_000e18);

uint256[] memory depositAmountLD = new uint256[](3);

for (uint256 i; i < assetsCount; ++i) {
depositAmountLD[i] = depositAmount * 10 ** ERC20(mainConfig.assets[i]).decimals();
}

// mint a bunch of extra tokens to the vault for if rate increased
deal(mainConfig.base, mainConfig.boringVault, depositAmount);
uint256 expecteShares;
Expand All @@ -220,9 +226,9 @@ contract LiveDeploy is ForkTest, DeployAll {
for (uint256 i; i < assetsCount; ++i) {
rateInQuoteBefore[i] = accountant.getRateInQuoteSafe(ERC20(mainConfig.assets[i]));
expectedSharesByAsset[i] =
depositAmount.mulDivDown(ONE_SHARE, accountant.getRateInQuoteSafe(ERC20(mainConfig.assets[i])));
depositAmountLD[i].mulDivDown(ONE_SHARE, accountant.getRateInQuoteSafe(ERC20(mainConfig.assets[i])));
expecteShares += expectedSharesByAsset[i];
_depositAssetWithApprove(ERC20(mainConfig.assets[i]), depositAmount);
_depositAssetWithApprove(ERC20(mainConfig.assets[i]), depositAmountLD[i]);
}

BoringVault boringVault = BoringVault(payable(mainConfig.boringVault));
Expand All @@ -241,9 +247,9 @@ contract LiveDeploy is ForkTest, DeployAll {
);

// mint extra assets for vault to give out
deal(mainConfig.assets[i], mainConfig.boringVault, depositAmount * 2);
deal(mainConfig.assets[i], mainConfig.boringVault, depositAmountLD[i] * 2);

uint256 expectedAssetsBack = ((depositAmount) * rateChange / 10_000);
uint256 expectedAssetsBack = ((depositAmountLD[i]) * rateChange / 10_000);

uint256 assetsOut = expectedSharesByAsset[i].mulDivDown(
accountant.getRateInQuoteSafe(ERC20(mainConfig.assets[i])), ONE_SHARE
Expand All @@ -265,34 +271,55 @@ contract LiveDeploy is ForkTest, DeployAll {
}
}

function testDepositASupportedAsset(uint256 depositAmount, uint256 indexOfSupported) public {
function testDepositASupportedAssetOnly(uint256 depositAmount, uint256 indexOfSupported) public {
uint256 assetsCount = mainConfig.assets.length;
indexOfSupported = bound(indexOfSupported, 0, assetsCount);
depositAmount = bound(depositAmount, 1, 10_000e18);

uint256[] memory depositAmountLD = new uint256[](3);

uint256 sharesDecimals = BoringVault(payable(mainConfig.boringVault)).decimals();
for (uint256 i; i < assetsCount; ++i) {
uint256 quoteDecimals = ERC20(mainConfig.assets[i]).decimals();

// `getRateInQuote` loses precision if the quote decimal is less than the shares decimals
require(quoteDecimals >= sharesDecimals, "quoteDecimals must be greater than or equal to sharesDecimals");

// deposit = quoteDecimals * sharesDecimals / quoteDecimals
// assuming internal rate calculation is precise, any deposit amount
// in decimals < 1e(quoteDecimals - sharesDecimals) will truncate to zero
depositAmountLD[i] = bound(depositAmount, 10 ** (quoteDecimals - sharesDecimals), 10_000e18);

console2.log("depositAmountLD[i]: ", depositAmountLD[i]);
}

uint256 expecteShares;
AccountantWithRateProviders accountant = AccountantWithRateProviders(mainConfig.accountant);
uint256[] memory expectedSharesByAsset = new uint256[](assetsCount);
for (uint256 i; i < assetsCount; ++i) {
expectedSharesByAsset[i] =
depositAmount.mulDivDown(ONE_SHARE, accountant.getRateInQuoteSafe(ERC20(mainConfig.assets[i])));
depositAmountLD[i].mulDivDown(ONE_SHARE, accountant.getRateInQuoteSafe(ERC20(mainConfig.assets[i])));
expecteShares += expectedSharesByAsset[i];

_depositAssetWithApprove(ERC20(mainConfig.assets[i]), depositAmount);
_depositAssetWithApprove(ERC20(mainConfig.assets[i]), depositAmountLD[i]);
}

BoringVault boringVault = BoringVault(payable(mainConfig.boringVault));
assertEq(boringVault.balanceOf(address(this)), expecteShares, "Should have received expected shares");

// withdrawal the assets for the same amount back
for (uint256 i; i < assetsCount; ++i) {
TellerWithMultiAssetSupport(mainConfig.teller).bulkWithdraw(
ERC20(mainConfig.assets[i]), expectedSharesByAsset[i], depositAmount - 1, address(this)
// For minimum amount out, zero out the last number of digits equal to (quoteDecimals - sharesDecimals)
uint256 decimalsDiff = 10 ** (ERC20(mainConfig.assets[i]).decimals() - sharesDecimals);
uint256 minimumAssetsOut = depositAmountLD[i] / decimalsDiff * decimalsDiff;

uint256 receiveAmountLD = TellerWithMultiAssetSupport(mainConfig.teller).bulkWithdraw(
ERC20(mainConfig.assets[i]), expectedSharesByAsset[i], minimumAssetsOut, address(this)
);
assertApproxEqAbs(
ERC20(mainConfig.assets[i]).balanceOf(address(this)),
depositAmount,
1,
receiveAmountLD,
depositAmountLD[i],
decimalsDiff,
"Should have been able to withdraw back the depositAmounts"
);
}
Expand Down
Loading