New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Test With Different Decimals #33

Open

junkim012 wants to merge 1 commit into master from jun/diff-decimals-live-test

+40 −13

Contributor

junkim012 commented Nov 2, 2024

Old live test treated all the quote asset amounts the same regardless of the different decimals.
This would cause the live test to revert when the shares amount to mint truncates to zero.
This PR makes the live test be compatible with different decimals, and adds additional checks to revert when precision is lost in the getRateInQuote.


          test: make the live deploy test compatible with quote assets of diffe…

008052d

…rent decimals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet