Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1503 agency logo not displaying #1512

Merged
merged 3 commits into from
Jan 13, 2025
Merged

1503 agency logo not displaying #1512

merged 3 commits into from
Jan 13, 2025

Conversation

kkrug
Copy link
Contributor

@kkrug kkrug commented Jan 13, 2025

Description

[Provide a brief description of the changes implemented in this pull request.]

Related Issues

[Reference any related issues, if applicable.]

Changes Made

  • [List the specific changes made in bullet points.]

Screenshots (if applicable)

[Include screenshots to visually demonstrate changes, if relevant.]

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.
  • Build has been approved for deployment in CircleCI.

@kkrug kkrug requested a review from jdonis January 13, 2025 16:14
@kkrug kkrug linked an issue Jan 13, 2025 that may be closed by this pull request
Agency Logo Not Displaying on Challenge Page #1503
Open
28 tasks
@kkrug kkrug added this to the Sprint 01/14/25 milestone Jan 13, 2025
jdonis
jdonis approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jdonis jdonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@jdonis jdonis merged commit 8992e33 into staging Jan 13, 2025
5 checks passed
@jdonis jdonis deleted the 1503-Agency-Logo-Not-Displaying branch January 13, 2025 16:20
@kkrug kkrug restored the 1503-Agency-Logo-Not-Displaying branch January 13, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonis jdonis jdonis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 01/14/25
Development

Successfully merging this pull request may close these issues.

Agency Logo Not Displaying on Challenge Page
2 participants
@kkrug @jdonis