Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agency Logo Not Displaying on Challenge Page #1503

Open
22 of 28 tasks
TCKapGrp opened this issue Jan 9, 2025 · 3 comments · Fixed by #1506, #1507, #1511, #1512 or #1513
Open
22 of 28 tasks

Agency Logo Not Displaying on Challenge Page #1503

TCKapGrp opened this issue Jan 9, 2025 · 3 comments · Fixed by #1506, #1507, #1511, #1512 or #1513
Assignees
Labels
bug Something isn't working Ready to test

Comments

@TCKapGrp
Copy link

TCKapGrp commented Jan 9, 2025

User story
As a Challenge Manager, in order to provide important information and to instill confidence in my potential solvers, I would like the agency logo to be displayed on my challenge's page.

Image

Acceptance criteria:

  • Agency Logo is displayed on the challenge page

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
  • [] Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
  • [ ] Database changes have been peer reviewed for index changes and performance bottlenecks
  • [ ] PR that changes or adds UI
    • [ ] include a screenshot of the WAVE report for the altered pages
    • [ ] Confirm changes were validated for mobile responsiveness
  • PR approved / Peer reviewed
  • Security scans passed
  • Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
  • Feature toggles if appropriate
  • Deploy to staging
  • Move card to testing column in the board

Staging

  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
  • [ ] Color contrast compliance
  • Screen reader testing
  • Usability testing: mobile and desktop (Tracy or Marni)
  • Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
    • [ x] Windows/Chrome
    • [x ] Windows/Edge
    • [ x] Mac/Chrome
    • Mac/Safari
    • iOS/Safari
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@TCKapGrp TCKapGrp added the bug Something isn't working label Jan 9, 2025
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 01/14/25 milestone Jan 10, 2025
@r-bartlett-gsa r-bartlett-gsa changed the title Agency Logo Bug Agency Logo Not Displaying on Challenge Page Jan 10, 2025
@r-bartlett-gsa
Copy link
Member

kkrug added a commit that referenced this issue Jan 10, 2025
Fix URI Encoding
kkrug added a commit that referenced this issue Jan 10, 2025
@r-bartlett-gsa r-bartlett-gsa linked a pull request Jan 10, 2025 that will close this issue
11 tasks
@kkrug kkrug linked a pull request Jan 10, 2025 that will close this issue
kkrug added a commit that referenced this issue Jan 13, 2025
@kkrug kkrug linked a pull request Jan 13, 2025 that will close this issue
11 tasks
jdonis added a commit that referenced this issue Jan 13, 2025
Agency Logo Not Displaying on Challenge Page #1503
@kkrug kkrug linked a pull request Jan 13, 2025 that will close this issue
11 tasks
@r-bartlett-gsa r-bartlett-gsa linked a pull request Jan 13, 2025 that will close this issue
11 tasks
jdonis added a commit that referenced this issue Jan 13, 2025
Agency Logo Not Displaying on Challenge Page #1503
@kkrug kkrug linked a pull request Jan 13, 2025 that will close this issue
7 tasks
jdonis added a commit that referenced this issue Jan 13, 2025
Agency Logo Not Displaying on Challenge Page #1503
kkrug added a commit that referenced this issue Jan 13, 2025
@r-bartlett-gsa
Copy link
Member

@kkrug Since this is in Testing column, is it ready for QA on staging?
Also, can you please review DoD checklist and check the appropriate items.

@kkrug
Copy link
Contributor

kkrug commented Jan 14, 2025

@r-bartlett-gsa This is ready for QA testing

@kkrug kkrug linked a pull request Jan 21, 2025 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment