Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[56-FIX] shared session logout error #1448

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[56-FIX] shared session logout error #1448

merged 1 commit into from
Oct 16, 2024

Conversation

cpreisinger
Copy link
Contributor

Description

[Provide a brief description of the changes implemented in this pull request.]

Related Issues

[Reference any related issues, if applicable.]

Changes Made

  • [List the specific changes made in bullet points.]

Screenshots (if applicable)

[Include screenshots to visually demonstrate changes, if relevant.]

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.

@cpreisinger cpreisinger requested a review from stepchud October 14, 2024 04:42
@cpreisinger cpreisinger self-assigned this Oct 14, 2024
@cpreisinger cpreisinger changed the base branch from dev to eval-main October 14, 2024 04:42
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 10/22/24 milestone Oct 15, 2024
@stepchud stepchud merged commit 10a39f7 into eval-main Oct 16, 2024
5 of 6 checks passed
@stepchud stepchud deleted the 56/fix/shared-session-logout-error branch October 16, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepchud stepchud stepchud approved these changes

Assignees

@cpreisinger cpreisinger

Labels
None yet
Projects
None yet
Milestone
Sprint 10/22/24
Development

Successfully merging this pull request may close these issues.
3 participants
@cpreisinger @stepchud @r-bartlett-gsa