Merge pull request #1448 from GSA/56/fix/shared-session-logout-error

[56-FIX] shared session logout error
GSA · Oct 16, 2024 · 10a39f7 · 10a39f7
2 parents 1f681c4 + 51d61b8
commit 10a39f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/web/controllers/session_controller.ex b/lib/web/controllers/session_controller.ex
@@ -181,6 +181,9 @@ defmodule Web.SessionController do
   end
 
   defp clear_rails_session(conn) do
-    delete_resp_cookie(conn, "_challenge_platform_key")
+    domain = Application.get_env(:challenge_gov, :session_cookie_domain)
+    secure = Mix.env() != :dev
+
+    delete_resp_cookie(conn, "_challenge_platform_key", domain: domain, secure: secure)
   end
 end
diff --git a/lib/web/endpoint.ex b/lib/web/endpoint.ex
@@ -12,6 +12,7 @@ defmodule Web.Endpoint do
     store: :cookie,
     key: "_challenge_gov_key",
     domain: Application.compile_env(:challenge_gov, :session_cookie_domain),
+    secure: Mix.env() != :dev,
     same_site: "Lax",
     signing_salt: "+S7HWPoL"
   ]