-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce IterRef
trait for deserialization
#73
Merged
ncpenke
merged 3 commits into
DataEngineeringLabs:feature/v0.4.0
from
aldanor:feature/gat
Oct 10, 2022
+76
−40
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
## Changelog | ||
|
||
All notable changes to `arrow2-convert` project will be documented in this file. | ||
|
||
## [Unreleased] | ||
## [0.4.0] | ||
### Changed | ||
- MSRV is bumped to 1.65.0 due to dependency on GATs (#73, @aldanor). | ||
- `ArrowDeserialize` can now be used as a standalone trait bound (#73, @aldanor). | ||
|
||
## [0.3.1] - 2022-09-29 | ||
### Changed | ||
- Update arrow2 version to 0.14 (#66, @ncpenke). | ||
|
||
## [0.3.0] - 2022-08-25 | ||
### Added | ||
- Add support for converting to `Chunk` (#44, @ncpenke). | ||
- Add support for `i128` (#48, @ncpenke). | ||
- Add support for enums (#37, @ncpenke). | ||
- Add support for flattening chunks (#56, @nielsmeima). | ||
|
||
### Changed | ||
- Serialize escaped Rust identifiers unescaped (#59, @teymour-aldridge). | ||
- Update arrow2 version to 0.13 (#61, @teymour-aldridge). | ||
|
||
## [0.2.0] - 2022-06-13 | ||
### Added | ||
- Add support for `FixedSizeBinary` and `FixedSizeList` (#30, @ncpenke). | ||
|
||
### Changed | ||
- Update arrow2 version to 0.12 (#38, @joshuataylor). | ||
|
||
## [0.1.0] - 2022-03-03 | ||
Initial crate release. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncpenke I was wondering about this unwrap - can it panic?... This doesn't look too nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldanor In theory it can, though we do a top-level schema check. But if the underlying arrow structure is different than the schema it advertises, then we can panic. I'll fix it in my upcoming change. I'll add you as a reviewer so that you can include any other feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldanor Just a heads up another thing we need to do is introduce our own error type (#54). We're currently piggybacking-off arrow2's type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I can take on that (the error type).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm almost done with my changes. I just changed the unwrap to an Option, and will leave the error type change to you.