Introduce IterRef trait for deserialization
#73
Conversation
|
Wonder if we can get rid of |
|
@aldanor Thanks for adding the changelog and the changes. I think we may be able to remove the |
| @@ -71,11 +88,11 @@ macro_rules! impl_arrow_array { | |||
| impl ArrowArray for $array { | |||
| type BaseArrayType = Self; | |||
|
|
|||
| fn iter_from_array_ref(b: &dyn Array) -> <&Self as IntoIterator>::IntoIter { | |||
| fn iter_from_array_ref(b: &dyn Array) -> <Self as IterRef>::Iter<'_> { | |||
| b.as_any() | |||
| .downcast_ref::<Self::BaseArrayType>() | |||
| .unwrap() | |||
There was a problem hiding this comment.
@ncpenke I was wondering about this unwrap - can it panic?... This doesn't look too nice
There was a problem hiding this comment.
@aldanor In theory it can, though we do a top-level schema check. But if the underlying arrow structure is different than the schema it advertises, then we can panic. I'll fix it in my upcoming change. I'll add you as a reviewer so that you can include any other feedback.
There was a problem hiding this comment.
Yea, I can take on that (the error type).
There was a problem hiding this comment.
Thanks! I'm almost done with my changes. I just changed the unwrap to an Option, and will leave the error type change to you.
No description provided.