Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #127

Merged
merged 1 commit into from
Feb 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .changeset/two-meals-drive.md

This file was deleted.

24 changes: 24 additions & 0 deletions ember-headless-table/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
# ember-headless-table

## 1.4.3

### Patch Changes

- [#118](https://github.com/CrowdStrike/ember-headless-table/pull/118) [`c02d49d`](https://github.com/CrowdStrike/ember-headless-table/commit/c02d49d0fe4f98d77404abe87ff2d8e1aefb4139) Thanks [@NullVoxPopuli](https://github.com/NullVoxPopuli)! - Address an issue where instances of plugins would be held on to after a Table is destroyed.

This caused a memory leak due how plugins, and their associated metadata, held on to
Table instances, which in turn, held on to the owner / container.

This was caused by the utility methods in `ember-headless-table/plugins`,

- `preferences`
- `meta`
- `options`

Because data was stored in (Weak)Maps in module-space.
This alone isn't a problem, but they were never cleaned up when the table was destroyed.

Cleanup of these objects could have occured via `associateDestroyableChild` and `registerDestructor`
from `@ember/destroyable`, but it was easier to instead have this happen automatically via hosting the
data needed for the "plugins utils" on the table itself. Since each plugin util requires "some instance of something",
be that a row, column, or table, there is a direct path to the table, and therefor a direct way to access
memory-scoped (Weak)Maps.

## 1.4.2

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion ember-headless-table/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ember-headless-table",
"version": "1.4.2",
"version": "1.4.3",
"description": "An implementation of table behaviors for driving any table or table-like UI -- all without a UI (headless)",
"keywords": [
"ember-addon",
Expand Down