Version Packages #127
Merged
Version Packages #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Patch Changes
#118
c02d49dThanks @NullVoxPopuli! - Address an issue where instances of plugins would be held on to after a Table is destroyed.This caused a memory leak due how plugins, and their associated metadata, held on to
Table instances, which in turn, held on to the owner / container.
This was caused by the utility methods in
ember-headless-table/plugins,preferencesmetaoptionsBecause data was stored in (Weak)Maps in module-space.
This alone isn't a problem, but they were never cleaned up when the table was destroyed.
Cleanup of these objects could have occured via
associateDestroyableChildandregisterDestructorfrom
@ember/destroyable, but it was easier to instead have this happen automatically via hosting thedata needed for the "plugins utils" on the table itself. Since each plugin util requires "some instance of something",
be that a row, column, or table, there is a direct path to the table, and therefor a direct way to access
memory-scoped (Weak)Maps.