Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Replace combination lock safes with electronically locked safes. #79062

Merged

Conversation

QuillInkwell
Copy link
Contributor

Summary

Mods "[Aftershock] Replace combination lock safes with electronically locked ones."

Purpose of change

It's a bit weird that in the far flung sci-fi future people are still using combination lock safes everywhere. It would be more theme fitting if they had electronic locks that could be hacked.

Describe the solution

Introduce a new safe furniture that has an electronic lock and uses the aftershock hacking EOC system. It's difficulty is a fair bit higher than everything hackable in the mod so far. So you'll need a character with pretty high computers skill to crack them. Or an oxy-torch to cut them open.

Replace all instances of safes, locked, closed, or open with the the electronic variant. (Within the confines of Aftershock.)

Describe alternatives you've considered

There is technically a gun-safe that already has an electronic lock. I opted against using this since it's difficulty is not customizable and it's hardcoded to always say "Hack Gun Safe". Which isn't ideal for anything that isn't a gun safe.

I considered making a less secure version for more mundane applications. But for now all safes are really hard to crack be they money safes, or bionic safes.

I copied the stats of I believe the standard furniture safe directly. I could have adjusted them but I think they were fine as they were.

Testing

I spawned and cracked open a bunch of safes. Verifying the functionality worked and was about at the level of difficulty I felt would be appropriate.

I also verified the structures are now spawning the new safes.

Additional context

@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Aftershock Anything to do with the Aftershock mod labels Jan 10, 2025
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 10, 2025
@Maleclypse Maleclypse merged commit bad461d into CleverRaven:master Jan 11, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants