-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outline from tour highlight and tweak border color #7548
Conversation
Test the previous changes of this PR with WordPress Playground. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #7548 +/- ##
=========================================
Coverage 51.82% 51.82%
Complexity 11307 11307
=========================================
Files 640 640
Lines 47979 47979
Branches 446 446
=========================================
Hits 24865 24865
Misses 22755 22755
Partials 359 359 Continue to review full report in Codecov by Sentry.
|
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cleeeeean <3
Proposed Changes
This PR removes the outline for the Sensei tour, as it was a bit too harsh and didn't enable the box shadow to truly stand out. It also removes the hard-coded color for classic themes and block themes that don't have a primary color defined, and uses
currentcolor
instead to better blend with the theme.Before
After
Testing Instructions
Pre-Merge Checklist