Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outline from tour highlight and tweak border color #7548

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Mar 18, 2024

Proposed Changes

This PR removes the outline for the Sensei tour, as it was a bit too harsh and didn't enable the box shadow to truly stand out. It also removes the hard-coded color for classic themes and block themes that don't have a primary color defined, and uses currentcolor instead to better blend with the theme.

Before

Screenshot 2024-03-18 at 3 31 24 PM

After

Screenshot 2024-03-18 at 3 32 15 PM

Testing Instructions

  1. Take the course tour and ensure there is no outline on the focused element and that the outline color looks good.
  2. Test on different themes.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep added this to the 4.22.0 milestone Mar 18, 2024
@donnapep donnapep self-assigned this Mar 18, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.82%. Comparing base (4e9c1a4) to head (b27f20c).
Report is 1 commits behind head on trunk.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7548   +/-   ##
=========================================
  Coverage     51.82%   51.82%           
  Complexity    11307    11307           
=========================================
  Files           640      640           
  Lines         47979    47979           
  Branches        446      446           
=========================================
  Hits          24865    24865           
  Misses        22755    22755           
  Partials        359      359           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3975bb0...b27f20c. Read the comment docs.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep requested a review from a team March 18, 2024 20:21
@donnapep donnapep changed the title Remove outline from tour highlight Remove outline from tour highlight and tweak border color Mar 18, 2024
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cleeeeean <3

@donnapep donnapep merged commit 414a627 into trunk Mar 19, 2024
25 checks passed
@donnapep donnapep deleted the update/tour-highlight-tweaks branch March 19, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants