-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add box-shadow back to the Sensei tour #7543
Conversation
Test the previous changes of this PR with WordPress Playground. |
WordPress Dependencies ReportThe No changes detected in the current commit. But the comment was left so it is possible to check for the edit history. This comment was automatically generated by the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #7543 +/- ##
=========================================
Coverage 51.78% 51.78%
Complexity 11307 11307
=========================================
Files 640 640
Lines 48115 48115
Branches 467 467
=========================================
Hits 24914 24914
Misses 22822 22822
Partials 379 379 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…es-position-conflict-handler
This reverts commit 50ff569.
Test the previous changes of this PR with WordPress Playground. |
@@ -19,8 +23,7 @@ $border-color: var(--wp--preset--color--primary, currentcolor); | |||
box-shadow: 0 0 $shadow-width $border-color !important; | |||
|
|||
&.sensei-tour-highlight--inset { | |||
outline: none !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I just took the opportunity to remove this property that is not needed anymore after #7548. And I also removed the double ;
.
Test the previous changes of this PR with WordPress Playground. |
Resolves #7504
Based off of #7538
Proposed Changes
After thinking about the proposed options in the issue, I decided to go with the one to hide metaboxes. Making something with a dynamic position doesn't seem something safe to handle without issues, and changing the position to the top I don't think would be nice.I think this approach is nice like a "focus mode" when the tour is open explaining the features.Testing Instructions
Pre-Merge Checklist