Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour of edit person in loan view #124

Merged
merged 2 commits into from
Apr 4, 2024

Conform to checkstyle and fix tests

60266ad
Select commit
Loading
Failed to load commit list.
Merged

Fix behaviour of edit person in loan view #124

Conform to checkstyle and fix tests
60266ad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 4, 2024 in 1s

47.02% (-0.04%) compared to 8b0e1d6

View this Pull Request on Codecov

47.02% (-0.04%) compared to 8b0e1d6

Details

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 47.02%. Comparing base (8b0e1d6) to head (60266ad).

Files Patch % Lines
...rc/main/java/seedu/address/model/ModelManager.java 42.85% 3 Missing and 1 partial ⚠️
...java/seedu/address/logic/commands/EditCommand.java 0.00% 2 Missing and 1 partial ⚠️
.../seedu/address/logic/commands/ViewLoanCommand.java 0.00% 1 Missing ⚠️
...seedu/address/logic/commands/ViewLoansCommand.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     47.06%   47.02%   -0.04%     
- Complexity      433      434       +1     
============================================
  Files            99       99              
  Lines          2267     2271       +4     
  Branches        227      227              
============================================
+ Hits           1067     1068       +1     
- Misses         1155     1156       +1     
- Partials         45       47       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov