Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour of edit person in loan view #124

Merged

Conversation

narwhalsilent
Copy link

Fix #120.

Behaviour changes:
When calling edit in loan view, the only things changed in GUI are the edited fields.

Code changes:

  • Create new boolean property in ModelManager called isShownAllLoans.
  • Refactor and overload ModelManager.updateFilteredLoanList().
  • Change viewloan and edit to reflect the changes.

- Create new boolean property in `ModelManager` called `isShownAllLoans`
- Refactor and overload `ModelManager.updateFilteredLoanList()`
- Change `viewloan` and `edit` to reflect the changes
@narwhalsilent narwhalsilent added this to the v1.3 milestone Apr 4, 2024
@narwhalsilent narwhalsilent self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 47.02%. Comparing base (8b0e1d6) to head (60266ad).

Files Patch % Lines
...rc/main/java/seedu/address/model/ModelManager.java 42.85% 3 Missing and 1 partial ⚠️
...java/seedu/address/logic/commands/EditCommand.java 0.00% 2 Missing and 1 partial ⚠️
.../seedu/address/logic/commands/ViewLoanCommand.java 0.00% 1 Missing ⚠️
...seedu/address/logic/commands/ViewLoansCommand.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     47.06%   47.02%   -0.04%     
- Complexity      433      434       +1     
============================================
  Files            99       99              
  Lines          2267     2271       +4     
  Branches        227      227              
============================================
+ Hits           1067     1068       +1     
- Misses         1155     1156       +1     
- Partials         45       47       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@marcus-ny marcus-ny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm!

@marcus-ny marcus-ny merged commit 544e841 into AY2324S2-CS2103T-W13-1:master Apr 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong view shown after viewloan <INDEX> and edit person command
2 participants