Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ISSM to GitHub repo #172

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Migrate ISSM to GitHub repo #172

merged 2 commits into from
Dec 2, 2024

Conversation

aidanheerdegen
Copy link
Member

Add support for new ISSM GitHub repo.

Closes #167

@aidanheerdegen
ISSM:
47ae691 
- Change to git address. Added url_for_version function
- Add url_for_version function
- Add release version
@aidanheerdegen aidanheerdegen mentioned this pull request Nov 28, 2024
Closed
@aidanheerdegen
Copy link
Member Author

As noted in the issue, compiles successfully with this change

#167 (comment)

But does require gcc/13: `spack install issm %gcc@13

Should this also be in the package recipe until Reference-ScaLAPACK/scalapack#97 is resolved?

harshula
harshula reviewed Nov 28, 2024
View reviewed changes
packages/issm/package.py Outdated Show resolved Hide resolved
@aidanheerdegen aidanheerdegen merged commit ff2fbc0 into main Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshula harshula harshula approved these changes

@angus-g angus-g Awaiting requested review from angus-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ISSM: transition to GitHub repo
2 participants
@aidanheerdegen @harshula