-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Multi-Language Support to Jumpserver #2969
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,14 @@ additionalProperties: | |
- Security | ||
shortDescZh: 广受欢迎的开源堡垒机 | ||
shortDescEn: The world's first open-source Bastion Host | ||
description: | ||
en: The world's first open-source Bastion Host | ||
ja: 世界初のオープンソースのバスティオンホスト | ||
ms: Bastion Host sumber terbuka pertama di dunia | ||
pt-br: O primeiro Bastion Host de código aberto do mundo | ||
ru: Первый в мире открытый Bastion Host | ||
zh-Hant: 全球首個開源堡壘主機 | ||
zh: 广受欢迎的开源堡垒机 | ||
type: tool | ||
crossVersionUpdate: false | ||
limit: 1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The only issue with this code is that while the "description" field has multiple translations, not all languages are included for every translation. It would be beneficial to include Spanish (es) and French (fr). |
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provided diff shows several changes to various configuration parameters and labels in a YAML/JSON-like format. Here's an analysis of the changes:
Password Field Changes:
type
field for two fields (password
) is changed consistently throughout to maintain consistency.Default Values:
"false"
and"ERROR"
, indicating they have no apparent changes needed.Environment Variables:
BOOTSTRAP_TOKEN
,DEBUG
,LOG_LEVEL
, etc.) are kept consistent across languages (e.g., both "English", "Japanese").Labels:
Cryptographic signing
,Bootstrap token
,Debug mode
,Log level
, etc.). These new translations ensure better support for multiple linguistic environments.Japanese ('日本語'), Malay ('Bahasa Melayu'),
Portuguese Brazilian ('Português Brasileiro'), Russian ('Русский язык'),
Turkish ('Türkçe'), Vietnamese ('Tiếng Việt').
Service Types:
Port Fields:
However, it’s important to note that there isn’t anything concerning or unusual about these specific changes since they appear to be updating existing configurations while providing comprehensive internationalization through multilingual labels.
Overall, this diff adds necessary language support without altering core functionality in terms of parameter structure or logic.