Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Multi-Language Support to Jumpserver #2969

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

zhengkunwang223
Copy link
Member

No description provided.

Copy link

f2c-ci-robot bot commented Jan 14, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ru: ДОМИНЫ
zh-Hant: 領域
zh: 域名 No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided diff shows several changes to various configuration parameters and labels in a YAML/JSON-like format. Here's an analysis of the changes:

  1. Password Field Changes:

    • The type field for two fields (password) is changed consistently throughout to maintain consistency.
  2. Default Values:

    • Some default values remain unchanged, such as "false" and "ERROR", indicating they have no apparent changes needed.
  3. Environment Variables:

    • Various environment variable names (BOOTSTRAP_TOKEN, DEBUG, LOG_LEVEL, etc.) are kept consistent across languages (e.g., both "English", "Japanese").
  4. Labels:

    • Multiple new entries with translated labels added for various properties (Cryptographic signing, Bootstrap token, Debug mode, Log level, etc.). These new translations ensure better support for multiple linguistic environments.
    • Translated labels include: Chinese simplified ("简体中文"), Chinese traditional ("繁體中文"),
      Japanese ('日本語'), Malay ('Bahasa Melayu'),
      Portuguese Brazilian ('Português Brasileiro'), Russian ('Русский язык'),
      Turkish ('Türkçe'), Vietnamese ('Tiếng Việt').
  5. Service Types:

    • Label additions for database services like MySQL/MariaDB and Redis add more clarity on each service type.
  6. Port Fields:

    • Labels for port-specific fields also underwent translation.

However, it’s important to note that there isn’t anything concerning or unusual about these specific changes since they appear to be updating existing configurations while providing comprehensive internationalization through multilingual labels.

Overall, this diff adds necessary language support without altering core functionality in terms of parameter structure or logic.

pt-br: O primeiro Bastion Host de código aberto do mundo
ru: Первый в мире открытый Bastion Host
zh-Hant: 全球首個開源堡壘主機
zh: 广受欢迎的开源堡垒机
type: tool
crossVersionUpdate: false
limit: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue with this code is that while the "description" field has multiple translations, not all languages are included for every translation. It would be beneficial to include Spanish (es) and French (fr).

@wanghe-fit2cloud wanghe-fit2cloud merged commit 3c04298 into dev Jan 14, 2025
1 of 2 checks passed
@wanghe-fit2cloud wanghe-fit2cloud deleted the pr@dev@jumpserver branch January 14, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants