Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jets: non-sham dashboard #92

Merged
merged 18 commits into from
Oct 18, 2023
Merged

jets: non-sham dashboard #92

merged 18 commits into from
Oct 18, 2023

Conversation

eamsden
Copy link
Collaborator

@eamsden eamsden commented Sep 22, 2023 •
edited
Loading

The tree-walking interpreter receives a proper jet dashboard, where %fast hints register cores in cold state, paths + battery axes to be jetted are written in a literal (hot state), and warm state used for matching is regenerated whenever cold state changes.

TODO

  • sham hints are commented out. Do they stay or do they go? @philipcmonk
    • stay but disabled. We probably want a feature in the crate.
  • We need an interpreter context data structure. A newt, cold/warm/hot states, and (soon) persistent caches is too much to pass around as separate parameters.
  • Jets will need access to interpreter context to enable jetting +mink.

@eamsden eamsden mentioned this pull request Sep 23, 2023
Closed
@eamsden eamsden marked this pull request as ready for review September 28, 2023 04:00
@eamsden
Copy link
Collaborator Author

eamsden commented Sep 28, 2023

@ashelkovnykov @philipcmonk this is ready for review now

@eamsden eamsden force-pushed the eamsden/fast-jets branch from 1afcbcf to 3022bf9 Compare October 2, 2023 04:02
ashelkovnykov
ashelkovnykov suggested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@ashelkovnykov ashelkovnykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial pair review w/ @eamsden

rust/ares/src/hamt.rs Outdated Show resolved Hide resolved
rust/ares/src/interpreter.rs Outdated Show resolved Hide resolved
rust/ares/src/interpreter.rs Outdated Show resolved Hide resolved
rust/ares/src/interpreter.rs Outdated Show resolved Hide resolved
rust/ares/src/interpreter.rs Outdated Show resolved Hide resolved
rust/ares/src/jets/cold.rs Show resolved Hide resolved
rust/ares/src/jets/cold.rs Outdated Show resolved Hide resolved
rust/ares/src/jets/cold.rs Outdated Show resolved Hide resolved
rust/ares/src/jets/cold.rs Outdated Show resolved Hide resolved
rust/ares/src/jets/cold.rs Outdated Show resolved Hide resolved
ashelkovnykov
ashelkovnykov suggested changes Oct 16, 2023
View reviewed changes
rust/ares/src/mem.rs Outdated Show resolved Hide resolved
rust/ares/src/mem.rs Outdated Show resolved Hide resolved
@ashelkovnykov ashelkovnykov self-requested a review October 18, 2023 01:44
eamsden
eamsden commented Oct 18, 2023
View reviewed changes
Copy link
Collaborator Author

@eamsden eamsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes but since I originally opened the PR I cannot officially approve them.

@ashelkovnykov ashelkovnykov merged commit 7be7c3b into status Oct 18, 2023
2 checks passed
@ashelkovnykov ashelkovnykov deleted the eamsden/fast-jets branch October 18, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashelkovnykov ashelkovnykov ashelkovnykov approved these changes

@philipcmonk philipcmonk Awaiting requested review from philipcmonk

@drbeefsupreme drbeefsupreme Awaiting requested review from drbeefsupreme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eamsden @ashelkovnykov