pma: fix memory corruption restoration bug #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we failed to record node partitions in the flist on restore. No we do so
|
|
PS. Please don't merge yet. Confirming this fix doesn't introduce any memory leaks in the backing file. |
ashelkovnykov
approved these changes
Apr 19, 2024
barter-simsum
deleted the
barter-simsum/pma-record-node-partitions-in-flist-on-restore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we failed to record node partitions in the flist on restore - leading to memory corruption. Now we do so.
btest.c for some reason ran without fault despite this bug. But when running ares as a serf of vere, this would routinely cause crashes in restoration. I've confirmed this PR fixes that and restoration seems to be behaving normally.